Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issue 2556423002: Missing style invalidation for :in-range and :out-of-range. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Missing style invalidation for :in-range and :out-of-range. Added pseudoStateChanged calls for those pseudos where we already did so for :valid and :invalid. R=tkent@chromium.org BUG=671745 Committed: https://crrev.com/edda97ea6721a9be143ed1e8b74f9117878ee94e Cr-Commit-Position: refs/heads/master@{#437415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/in-and-out-of-range-pseudo.html View 1 chunk +100 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rune
ptal
4 years ago (2016-12-08 10:25:55 UTC) #2
tkent
lgtm. Thanks!
4 years ago (2016-12-09 01:08:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556423002/1
4 years ago (2016-12-09 01:09:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:38:58 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-09 01:43:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edda97ea6721a9be143ed1e8b74f9117878ee94e
Cr-Commit-Position: refs/heads/master@{#437415}

Powered by Google App Engine
This is Rietveld 408576698