Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2556393003: [v8.runtime_stats] Update page-repeat to 3 for v8.runtime_stats.top_25 (Closed)

Created:
4 years ago by fmeawad
Modified:
4 years ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, Camillo Bruni, eyaich1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8.runtime_stats] Update page-repeat to 3 for v8.runtime_stats.top_25 The benchmark has been running for a couple of weeks now and a noticable noise is observed. We are changing the page-repeat to 3 to reduce the noise. Note to perf bot owners: This test currently runs on linux and mac, with a cycle time of ~25 minutes. It is expected that this cycle time will become 3x that number, i.e. ~1.5 hours. R=nednguyen@google.com, CC=cbruni@chromium.org,eyaich@chromium.org BUG=664318 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/e433914989869a14fe15f6369fd3149a1b3b7eb8 Cr-Commit-Position: refs/heads/master@{#437379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
fmeawad
PTAL
4 years ago (2016-12-08 15:52:02 UTC) #2
nednguyen
lgtm
4 years ago (2016-12-08 16:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556393003/1
4 years ago (2016-12-08 16:03:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82337)
4 years ago (2016-12-08 17:30:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556393003/1
4 years ago (2016-12-08 17:33:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82430)
4 years ago (2016-12-08 19:15:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556393003/1
4 years ago (2016-12-08 19:47:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82691)
4 years ago (2016-12-08 21:34:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556393003/1
4 years ago (2016-12-08 22:28:00 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 22:49:21 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-08 22:52:32 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e433914989869a14fe15f6369fd3149a1b3b7eb8
Cr-Commit-Position: refs/heads/master@{#437379}

Powered by Google App Engine
This is Rietveld 408576698