Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(110)

Issue 2556383002: Don't define log2 and log2f in blink for Android (Closed)

Created:
2 years, 3 months ago by brucedawson
Modified:
2 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't define log2 and log2f in blink for Android The definition of log2f in blink was causing problems on Windows and is no longer necessary. It is also unnecessary on Android and may also be causing problems there, so this change finishes removing the definitions. See crrev.com/2556383002 for details. Committed: https://crrev.com/def20b0a429121024fa0b148ad112787f7edb479 Cr-Commit-Position: refs/heads/master@{#437351}

Patch Set 1 #

Patch Set 2 : Merging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M third_party/WebKit/Source/wtf/MathExtras.h View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
brucedawson
This is a follow-up change to completely remove these functions. Presumably having this change build ...
2 years, 3 months ago (2016-12-08 20:50:18 UTC) #9
Nico
lgtm
2 years, 3 months ago (2016-12-08 21:07:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556383002/20001
2 years, 3 months ago (2016-12-08 21:19:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
2 years, 3 months ago (2016-12-08 21:35:46 UTC) #17
commit-bot: I haz the power
2 years, 3 months ago (2016-12-08 21:38:06 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/def20b0a429121024fa0b148ad112787f7edb479
Cr-Commit-Position: refs/heads/master@{#437351}

Powered by Google App Engine
This is Rietveld 408576698