Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2556373002: Revert: Detect floats to avoid or clear due to negative margin top (and followup) (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert: Detect floats to avoid or clear due to negative margin top (and followup) This patch reverts the following two patches: 1) Detect floats to avoid or clear due to negative margin top https://crrev.com/3c8d298acf826fc5337c526b1016a03b37c2656a 2) Stop searching for overhanging floats when the sibling's floats no longer overlap https://crrev.com/eb8f963f9a5030c0007500620eefaad7c2c2c490 This revert is due to a perf regression in the layout of floats. A followup patch will unskip the mossiella perf test that was skipped due to this regression. BUG=671645, 670325, 666487 TBR=robhogan@chromium.org Committed: https://crrev.com/24f05ee67737fcb83104ae4c033f87d5703ff703 Cr-Commit-Position: refs/heads/master@{#437194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -170 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-2.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-2-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-3.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-3-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-4.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-4-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-5.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-5-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-6.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-6-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/block/float/avoid-floats-when-negative-margin-top-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +15 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556373002/1
4 years ago (2016-12-08 03:25:26 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/81896)
4 years ago (2016-12-08 04:55:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556373002/1
4 years ago (2016-12-08 05:01:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 06:19:55 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 06:22:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24f05ee67737fcb83104ae4c033f87d5703ff703
Cr-Commit-Position: refs/heads/master@{#437194}

Powered by Google App Engine
This is Rietveld 408576698