Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

Issue 2556363003: Refactor cache counting into a separate helper class (Closed)
Patch Set: cleanup Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
diff --git a/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc b/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
index 5660dd277c4d0af66c80ff0207ba61ee922d1bc3..ff85583c51db5392e29164c666bb492cffad6df0 100644
--- a/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
+++ b/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
@@ -145,9 +145,7 @@ class ConditionalCacheDeletionHelperBrowserTest : public InProcessBrowserTest {
void DeleteEntries(
const base::Callback<bool(const disk_cache::Entry*)>& condition) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- ConditionalCacheDeletionHelper* helper = new ConditionalCacheDeletionHelper(
- backend_,
- condition);
+ auto* helper = new ConditionalCacheDeletionHelper(backend_, condition);
WaitForCompletion(helper->DeleteAndDestroySelfWhenFinished(done_callback_));
}
@@ -205,12 +203,7 @@ class ConditionalCacheDeletionHelperBrowserTest : public InProcessBrowserTest {
// that match the condition.
IN_PROC_BROWSER_TEST_F(ConditionalCacheDeletionHelperBrowserTest, Condition) {
// Create 5 entries.
- std::set<std::string> keys;
- keys.insert("123");
- keys.insert("47");
- keys.insert("56");
- keys.insert("81");
- keys.insert("42");
+ std::set<std::string> keys = {"123", "47", "56", "81", "42"};
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698