Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 2556333002: Detect change on video/viewport intersection when rendered remotely (Closed)
Patch Set: Use single timer to check viewport intersection change. Update tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index 540c9271134c84ac0359ee3f709e8c55e934a562..4eacafb934528f3ddeadcfcec473d011f3e1cc99 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -397,10 +397,12 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
WebMediaPlayer::TrackId getSelectedVideoTrackId() final;
bool isAutoplayingMuted() final;
void requestReload(const WebURL&) final;
+ void enableMonitorViewportIntersection(bool) final;
ojan 2016/12/14 00:39:08 I would have gone with a more generic name like "s
xjz 2016/12/14 00:55:05 Yes, currently this is only used to enable monitor
void loadTimerFired(TimerBase*);
void progressEventTimerFired(TimerBase*);
void playbackProgressTimerFired(TimerBase*);
+ void checkViewportIntersectionTimerFired(TimerBase*);
void startPlaybackProgressTimer();
void startProgressEventTimer();
void stopPeriodicTimers();
@@ -541,7 +543,6 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
void onVisibilityChangedForAutoplay(bool isVisible);
- void checkViewportIntersectionChanged();
void viewportFillDebouncerTimerFired(TimerBase*);
UnthrottledThreadTimer<HTMLMediaElement> m_loadTimer;
@@ -549,6 +550,7 @@ class CORE_EXPORT HTMLMediaElement : public HTMLElement,
UnthrottledThreadTimer<HTMLMediaElement> m_playbackProgressTimer;
UnthrottledThreadTimer<HTMLMediaElement> m_audioTracksTimer;
UnthrottledThreadTimer<HTMLMediaElement> m_viewportFillDebouncerTimer;
+ UnthrottledThreadTimer<HTMLMediaElement> m_checkViewportIntersectionTimer;
Member<TimeRanges> m_playedTimeRanges;
Member<GenericEventQueue> m_asyncEventQueue;

Powered by Google App Engine
This is Rietveld 408576698