third_party/WebKit/public/platform/WebMediaPlayer.h - Issue 2556333002: Detect change on video/viewport intersection when rendered remotely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2556333002: Detect change on video/viewport intersection when rendered remotely (Closed)

Patch Set: Fix nits. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/WebMediaPlayer.h

diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h

index f652d5bed866e5bbe8eadaf12b64aaab36c5f725..370c523b3e305502b6f660755ed29ba41538a44b 100644

--- a/third_party/WebKit/public/platform/WebMediaPlayer.h

+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h

@@ -262,7 +262,9 @@ class WebMediaPlayer {

virtual void exitedFullscreen() {}

// Inform WebMediaPlayer when the element starts/stops being the dominant

- // visible content.

+ // visible content. This will only be called after the monitoring of the

+ // intersection with viewport is activated by calling

+ // WebMediaPlayerClient::activateViewportIntersectionMonitoring().

virtual void becameDominantVisibleContent(bool isDominant) {}

virtual void enabledAudioTracksChanged(