Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2556333002: Detect change on video/viewport intersection when rendered remotely (Closed)
Patch Set: Add comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('j') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index f652d5bed866e5bbe8eadaf12b64aaab36c5f725..32edb0a26404bd22e5048ec277ec8807e5948587 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -262,7 +262,9 @@ class WebMediaPlayer {
virtual void exitedFullscreen() {}
// Inform WebMediaPlayer when the element starts/stops being the dominant
- // visible content.
+ // visible content. This will only be called after the monitoring of the
+ // intersection with viewport is activated by calling
+ // HTMLMediaElement::activateViewportIntersectionMonitoring().
xhwang 2016/12/15 20:31:11 s/HTMLMediaElement/WMPClient..
xjz 2016/12/15 20:42:37 Done.
virtual void becameDominantVisibleContent(bool isDominant) {}
virtual void enabledAudioTracksChanged(
« no previous file with comments | « third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('j') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698