Handle non-regular file types in the directory lister

runtime/bin/directory_macos.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_MACOS)
 
 #include "bin/directory.h"
 
 #include <dirent.h>     // NOLINT
@@ skipping 111 matching lines @@
       done_ = true;
       return kListError;
     }
     switch (entry.d_type) {
       case DT_DIR:
         if ((strcmp(entry.d_name, ".") == 0) ||
             (strcmp(entry.d_name, "..") == 0)) {
           return Next(listing);
         }
         return kListDirectory;
+      case DT_BLK:
+      case DT_CHR:
+      case DT_FIFO:
+      case DT_SOCK:
       case DT_REG:
         return kListFile;
       case DT_LNK:
         if (!listing->follow_links()) {
           return kListLink;
         }
       // Else fall through to next case.
       // Fall through.
       case DT_UNKNOWN: {
         // On some file systems the entry type is not determined by
@@ skipping 35 matching lines @@
             }
             return kListDirectory;
           }
         }
         if (S_ISDIR(entry_info.st_mode)) {
           if ((strcmp(entry.d_name, ".") == 0) ||
               (strcmp(entry.d_name, "..") == 0)) {
             return Next(listing);
           }
           return kListDirectory;
-        } else if (S_ISREG(entry_info.st_mode)) {
+        } else if (S_ISREG(entry_info.st_mode) || S_ISCHR(entry_info.st_mode) ||
+                   S_ISBLK(entry_info.st_mode) ||
+                   S_ISFIFO(entry_info.st_mode) ||
+                   S_ISSOCK(entry_info.st_mode)) {
           return kListFile;
         } else if (S_ISLNK(entry_info.st_mode)) {
           return kListLink;
+        } else {
+          FATAL1("Unexpected st_mode: %d\n", entry_info.st_mode);
+          return kListError;
         }
       }
 
       default:
-        break;
+        // We should have covered all the bases. If not, let's get an error.
+        FATAL1("Unexpected d_type: %d\n", entry.d_type);
+        return kListError;
     }
   }
   done_ = true;
 
   if (status != 0) {
     errno = status;
     return kListError;
   }
 
   return kListDone;
@@ skipping 244 matching lines @@
   if (exists != EXISTS) {
     return false;
   }
   return (NO_RETRY_EXPECTED(rename(path, new_path)) == 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)