Handle non-regular file types in the directory lister

Handle non-regular file types in the directory lister

fixes #28015

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/4f04970a13d2c5228481281aae3cffe26794dc91

[zra, 2016-12-07 22:49:49]

zra@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-12-08 12:48:28]

LGTM.

I'm fine with no tests (since this is really hard to add to the test framework),
but please run it once by hand for all the different file types on the different
architectures. (If you haven't already).

thanks.

[zra, 2016-12-08 17:59:24]

On 2016/12/08 12:48:28, floitsch wrote:
> LGTM.
> 
> I'm fine with no tests (since this is really hard to add to the test
framework),
> but please run it once by hand for all the different file types on the
different
> architectures. (If you haven't already).
> 
> thanks.

Listing /tmp and /dev on my Linux box appears to work, and probably covers all
the bases.

[zra, 2016-12-08 18:02:07]

Description was changed from

==========
Handle non-regular file types in the directory lister

fixes #28015
==========

to

==========
Handle non-regular file types in the directory lister

fixes #28015

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4f04970a13d2c5228481281aae3cffe26794dc91
==========

[zra, 2016-12-08 18:02:08]

Committed patchset #2 (id:20001) manually as
4f04970a13d2c5228481281aae3cffe26794dc91 (presubmit successful).