Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2556273002: [Merge-M56] arc: Fix double provisioning failure reporting. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge-M56] arc: Fix double provisioning failure reporting. In case a auth code request failure occurs, error is reported. In many cases this causes Arc bridge stop and mojo close. On mojo close Cancel exception is reported to Arc provision step. It itself sends one more Unknown error that overrides previous error. This CL ignore second and next error. TEST=Manually on device. Emulate server error and instead unknown error server communication error is shown. BUG=b/33347895 BUG=671667 TBR=lhchavez@chromium.org TBR=hidehiko@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2554743003 Cr-Commit-Position: refs/heads/master@{#436794} (cherry picked from commit 42d24efdbeff42ab083b9d3b59ddb1a4753b370e)

Patch Set 1 #

Patch Set 2 : resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service_unittest.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556273002/20001
4 years ago (2016-12-07 21:36:31 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-07 21:39:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698