Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2556253004: Set empty namespaces for public/exportNamespace of synthetic libraries. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/resynthesize.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index 3c9b0488ca7989ec60bad579bc6167335208fac5..aa69a705e1edde35b3cc3b8e720a9cf8dfdbbc00 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -4677,14 +4677,12 @@ typedef F();''');
test_unresolved_import() {
allowMissingFiles = true;
- checkLibrary("import 'foo.dart';", allowErrors: true);
- }
-
- test_unresolved_import_deferred() {
Paul Berry 2016/12/08 12:58:22 Why are we getting rid of this test?
scheglov 2016/12/08 15:53:09 I realized that this test does not add anything ne
- allowMissingFiles = true;
LibraryElementImpl library =
- checkLibrary("import 'missing.dart' deferred as p;");
- expect(library.imports[0].importedLibrary.loadLibraryFunction, isNotNull);
+ checkLibrary("import 'foo.dart';", allowErrors: true);
+ LibraryElement importedLibrary = library.imports[0].importedLibrary;
+ expect(importedLibrary.loadLibraryFunction, isNotNull);
+ expect(importedLibrary.publicNamespace, isNotNull);
+ expect(importedLibrary.exportNamespace, isNotNull);
}
test_unresolved_part() {
« no previous file with comments | « pkg/analyzer/lib/src/summary/resynthesize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698