Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2556253004: Set empty namespaces for public/exportNamespace of synthetic libraries. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set empty namespaces for public/exportNamespace of synthetic libraries. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/685b956840b848813747ee0c5f3401416e23edcf

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +12 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +5 lines, -7 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years ago (2016-12-08 02:54:39 UTC) #1
Paul Berry
https://codereview.chromium.org/2556253004/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (left): https://codereview.chromium.org/2556253004/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#oldcode4683 pkg/analyzer/test/src/summary/resynthesize_common.dart:4683: test_unresolved_import_deferred() { Why are we getting rid of this ...
4 years ago (2016-12-08 12:58:22 UTC) #2
Brian Wilkerson
lgtm, modulo Paul's question
4 years ago (2016-12-08 14:49:53 UTC) #3
scheglov
https://codereview.chromium.org/2556253004/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (left): https://codereview.chromium.org/2556253004/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#oldcode4683 pkg/analyzer/test/src/summary/resynthesize_common.dart:4683: test_unresolved_import_deferred() { On 2016/12/08 12:58:22, Paul Berry wrote: > ...
4 years ago (2016-12-08 15:53:09 UTC) #4
scheglov
4 years ago (2016-12-08 16:15:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
685b956840b848813747ee0c5f3401416e23edcf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698