Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: chrome/browser/chromeos/login/screens/eula_screen.cc

Issue 2556253002: cros: Fold EulaModel into EulaView. (Closed)
Patch Set: Initial upload Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/eula_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/eula_screen.cc b/chrome/browser/chromeos/login/screens/eula_screen.cc
index 3b2719fd8ea0fdc4ee2dd024b58b5dd1167c2800..d94aaab4c905163386e1c6d723743712792bf383 100644
--- a/chrome/browser/chromeos/login/screens/eula_screen.cc
+++ b/chrome/browser/chromeos/login/screens/eula_screen.cc
@@ -11,24 +11,30 @@
#include "chrome/browser/chromeos/customization/customization_document.h"
#include "chrome/browser/chromeos/login/screens/base_screen_delegate.h"
#include "chrome/browser/chromeos/login/screens/eula_view.h"
+#include "chrome/browser/chromeos/login/wizard_controller.h"
#include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
#include "chromeos/dbus/cryptohome_client.h"
#include "chromeos/dbus/dbus_method_call_status.h"
#include "chromeos/dbus/dbus_thread_manager.h"
namespace chromeos {
+namespace {
+constexpr const char kUserActionAcceptButtonClicked[] = "accept-button";
achuithb 2017/01/13 20:10:05 Looks a bit crowded, a newline before this line ma
jdufault 2017/01/14 00:03:29 Done.
+constexpr const char kUserActionBackButtonClicked[] = "back-button";
+constexpr const char kContextKeyUsageStatsEnabled[] = "usageStatsEnabled";
+} // namespace
achuithb 2017/01/13 20:10:05 Drop comment since the namespace is small
jdufault 2017/01/14 00:03:29 Keeping since I added newlines. I can remove if yo
EulaScreen::EulaScreen(BaseScreenDelegate* base_screen_delegate,
Delegate* delegate,
EulaView* view)
- : EulaModel(base_screen_delegate),
+ : BaseScreen(base_screen_delegate, OobeScreen::SCREEN_OOBE_EULA),
delegate_(delegate),
view_(view),
password_fetcher_(this) {
DCHECK(view_);
DCHECK(delegate_);
if (view_)
- view_->Bind(*this);
+ view_->Bind(this);
}
EulaScreen::~EulaScreen() {
@@ -42,7 +48,7 @@ void EulaScreen::Show() {
EmptyVoidDBusMethodCallback());
if (policy::DeviceCloudPolicyManagerChromeOS::GetZeroTouchEnrollmentMode() ==
policy::ZeroTouchEnrollmentMode::HANDS_OFF)
- OnUserAction(EulaModel::kUserActionAcceptButtonClicked);
+ OnUserAction(kUserActionAcceptButtonClicked);
else if (view_)
view_->Show();
}

Powered by Google App Engine
This is Rietveld 408576698