third_party/WebKit/Source/core/dom/IntersectionObservation.cpp - Issue 2556243003: IntersectionObserver: compute correct intersection ratio for 0x0 elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

Issue 2556243003: IntersectionObserver: compute correct intersection ratio for 0x0 elements (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

index 2ae1556fc10ddca7a031867902c3f74dde19c9c3..40edeb5ac586fcb50fdb3dd10c16b5757d3d0508 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

@@ -53,6 +53,7 @@ void IntersectionObservation::computeIntersectionObservations(

float newVisibleRatio = 0;

if (geometry.targetRect().isEmpty()) {

newThresholdIndex = geometry.doesIntersect() ? 1 : 0;

+ newVisibleRatio = geometry.doesIntersect() ? 1 : 0;

} else if (!geometry.doesIntersect()) {

newThresholdIndex = 0;

} else {