third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-visible.html - Issue 2556243003: IntersectionObserver: compute correct intersection ratio for 0x0 elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-visible.html

Issue 2556243003: IntersectionObserver: compute correct intersection ratio for 0x0 elements (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/js-test.js"></script>

	3 <script src="../resources/intersection-observer-helper-functions.js"></script>

	4 <div id='target' style='width:0px; height:0px'</div>"

	5 <script>

	6 description("Ensure that a visible zero-area element is given the correct inters ection ratio.");

	7

	8 var entries = [];

	9 var target;

	10

	11 onload = function() {

	12 target = document.getElementById("target");

	13 new IntersectionObserver((changes) => {

	14 entries.push(...changes);

	15 }).observe(target);

	16 waitForNotification(step0);

	17 };

	18

	19 function step0() {

	20 shouldBeEqualToNumber("entries.length", 1);

	21 if (entries.length > 0) {
	foolip 2016/12/08 16:28:59 The above line says that it should be true, so no The above line says that it should be true, so no conditional needed? (With testharness.js, the test will stop at the first failed assert.) Sami 2016/12/09 17:24:36 Very true, fixed. The existing tests had this guar Show quoted text On 2016/12/08 16:28:59, foolip (OOO Dec. 9) wrote: > The above line says that it should be true, so no conditional needed? (With > testharness.js, the test will stop at the first failed assert.) Very true, fixed. The existing tests had this guard for some reason...
	22 shouldBe("entries[0].intersectionRatio", "1");

	23 }

	24 finishJSTest();

	25 }

	26 </script>

OLD	NEW