third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-hidden.html - Issue 2556243003: IntersectionObserver: compute correct intersection ratio for 0x0 elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-hidden.html

Issue 2556243003: IntersectionObserver: compute correct intersection ratio for 0x0 elements (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-hidden-expected.txt » ('j') | third_party/WebKit/LayoutTests/intersection-observer/zero-area-element-visible.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/js-test.js"></script>
	foolip 2016/12/08 16:28:59 It looks like this test doesn't depend on any inte It looks like this test doesn't depend on any internal APIs, and intersection-observer-helper-functions.js doesn't either at a glance, can you write this using testharness.js for easier upstreaming to web-platform-tests later? Sami 2016/12/09 17:24:36 I'll give it a shot. This was just a carbon copy o Show quoted text On 2016/12/08 16:28:59, foolip wrote: > It looks like this test doesn't depend on any internal APIs, and > intersection-observer-helper-functions.js doesn't either at a glance, can you > write this using testharness.js for easier upstreaming to web-platform-tests > later? I'll give it a shot. This was just a carbon copy of an existing test here which explains some of the weirdness.
	3 <script src="../resources/intersection-observer-helper-functions.js"></script>

	4 <div id='target' style='width:0px; height:0px; position: fixed; top: -1000px'</d iv>"

	5 <script>

	6 description("Ensure that a hidden zero-area element is treated correctly.");
	foolip 2016/12/08 16:28:59 With testharness.js this can go in <title>, if the With testharness.js this can go in <title>, if there's just a single test in a file.
	7

	8 var entries = [];

	9 var target;

	10

	11 onload = function() {
	foolip 2016/12/08 16:28:59 Does the test need to wait for the window load eve Does the test need to wait for the window load event, if so, it'll have to be: async_test(t => { onload = t.step_func(() => { // stuff }); }) (Otherwise one less nesting level is possible.) Sami 2016/12/09 17:24:36 You're right -- there's no need to wait for anythi Show quoted text On 2016/12/08 16:28:59, foolip (OOO Dec. 9) wrote: > Does the test need to wait for the window load event, if so, it'll have to be: > > async_test(t => { > onload = t.step_func(() => { > // stuff > }); > }) > > (Otherwise one less nesting level is possible.) You're right -- there's no need to wait for anything to load here.
	12 target = document.getElementById("target");

	13 new IntersectionObserver((changes) => {

	14 entries.push(...changes);

	15 }).observe(target);

	16 waitForNotification(step0);
	foolip 2016/12/08 16:28:59 With testharness.js, this would be: waitForNotific With testharness.js, this would be: waitForNotification(t.step_func_done(() => { assert_equals(entries.length, 0); }); Sami 2016/12/09 17:24:36 Done. Show quoted text On 2016/12/08 16:28:59, foolip (OOO Dec. 9) wrote: > With testharness.js, this would be: > waitForNotification(t.step_func_done(() => { > assert_equals(entries.length, 0); > }); Done.
	17 };

	18

	19 function step0() {

	20 // Since the element is initially assumed to be hidden, there are no entries.

	21 shouldBeEqualToNumber("entries.length", 0);

	22 finishJSTest();

	23 }

	24 </script>

OLD	NEW