Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 2556213002: Revert of Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter. (Closed)

Created:
4 years ago by eakuefner
Modified:
4 years ago
Reviewers:
benjhayden
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter. (patchset #7 id:110001 of https://codereview.chromium.org/2538043005/ ) Reason for revert: Please send an email to telemetry-announce before landing this. Also, results_options is not the right place for the uploading logic. Original issue's description: > Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter. > > Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but > it does not convert TBMv1 Values to Histograms, nor does it read existing > results, nor does it support uploading. Also the name is wrong. > > This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and > re-conceptualizes it as a subclass of Html2OutputFormatter in order to support > converting TBMv1 Values to Histograms and uploading. > The new HistogramSetJsonOutputFormatter now also reads existing results. > > http://go/histogram-set-json-format > http://go/histogram-pipeline > > BUG=catapult:#2717 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/77ad967bf0a4a9358d57fe42a6fd2a83a422ff49 TBR=benjhayden@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2717 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/70578734ad34dbda9b76b1de59c48546815fdada

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
eakuefner
Created Revert of Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.
4 years ago (2016-12-07 18:36:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556213002/1
4 years ago (2016-12-07 18:36:17 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-07 18:36:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698