Chromium Code Reviews
DescriptionRevert of Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter. (patchset #7 id:110001 of https://codereview.chromium.org/2538043005/ )
Reason for revert:
Please send an email to telemetry-announce before landing this. Also, results_options is not the right place for the uploading logic.
Original issue's description:
> Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.
>
> Currently, run_benchmark --output=valueset dumps TBMv2 Histograms to JSON, but
> it does not convert TBMv1 Values to Histograms, nor does it read existing
> results, nor does it support uploading. Also the name is wrong.
>
> This CL renames ValueSetOutputFormatter to HistogramSetJsonOutputFormatter, and
> re-conceptualizes it as a subclass of Html2OutputFormatter in order to support
> converting TBMv1 Values to Histograms and uploading.
> The new HistogramSetJsonOutputFormatter now also reads existing results.
>
> http://go/histogram-set-json-format
> http://go/histogram-pipeline
>
> BUG=catapult:#2717
>
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/77ad967bf0a4a9358d57fe42a6fd2a83a422ff49
TBR=benjhayden@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#2717
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/70578734ad34dbda9b76b1de59c48546815fdada
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|