runtime/vm/object.cc - Issue 2556193003: VM: Make precompiler process constants/fields only once, avoid using pool.InfoAt()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2556193003: VM: Make precompiler process constants/fields only once, avoid using pool.InfoAt() (Closed)

Patch Set: Add ": public ValueObject" Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index ba603999d80e122a4dd3d688ef6b5c3ab92f08d8..f60ab345f95fa026c43b842d891884eb83e7c579 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -11602,8 +11602,8 @@ void ObjectPool::set_info_array(const TypedData& info_array) const {

ObjectPool::EntryType ObjectPool::InfoAt(intptr_t index) const {

- const TypedData& array = TypedData::Handle(info_array());

- return static_cast<EntryType>(array.GetInt8(index));

+ ObjectPoolInfo pool_info(*this);

+ return pool_info.InfoAt(index);

}