Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: extensions/renderer/script_context.h

Issue 2556153002: [Extensions] Convert more callers of CallModuleMethod (Closed)
Patch Set: revert doc change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index fad1dc22037d784ae3b5011c4398a7e55ff6184e..c53626ba60cead363bf11eee331ac0d757b8b8c2 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -19,6 +19,7 @@
#include "extensions/renderer/module_system.h"
#include "extensions/renderer/request_sender.h"
#include "extensions/renderer/safe_builtins.h"
+#include "extensions/renderer/script_injection_callback.h"
#include "gin/runner.h"
#include "url/gurl.h"
#include "v8/include/v8.h"
@@ -117,11 +118,16 @@ class ScriptContext : public RequestSender::Source {
// Safely calls the v8::Function, respecting the page load deferrer and
// possibly executing asynchronously.
// Doesn't catch exceptions; callers must do that if they want.
- // USE THIS METHOD RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
+ // USE THESE METHODS RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
// TODO(devlin): Remove the above variants in favor of this.
void SafeCallFunction(const v8::Local<v8::Function>& function,
int argc,
v8::Local<v8::Value> argv[]);
+ void SafeCallFunction(
+ const v8::Local<v8::Function>& function,
+ int argc,
+ v8::Local<v8::Value> argv[],
+ const ScriptInjectionCallback::CompleteCallback& callback);
void DispatchEvent(const char* event_name, v8::Local<v8::Array> args) const;
« no previous file with comments | « extensions/renderer/module_system.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698