android_webview/build/jarjar-rules.txt - Issue 255613003: Move ui and content resources into one location.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/build/jarjar-rules.txt

Issue 255613003: Move ui and content resources into one location. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	1 zap org.chromium.ui.R**
	Torne 2014/05/13 13:46:52 Is a the right thing here? Isn't that going to Is a the right thing here? Isn't that going to zap/rename anything whose name happens to start with an R in these packages? Do we maybe want an explicit rule for R, and then a separate one for R. instead? mkosiba (inactive) 2014/06/12 11:11:19 Good point. The resources are inner classes so we Show quoted text On 2014/05/13 13:46:52, Torne wrote: > Is a the right thing here? Isn't that going to zap/rename anything whose name > happens to start with an R in these packages? Do we maybe want an explicit rule > for R, and then a separate one for R.** instead? Good point. The resources are inner classes so we need a rule for R and a separate one for R$
	2 zap org.chromium.content.R**

	3 rule org.chromium.ui.R** com.android.org.chromium.R@1

	4 rule org.chromium.content.R** com.android.org.chromium.R@1

1 rule org.chromium.** com.android.@0	5 rule org.chromium.** com.android.@0

2 rule com.google.** com.android.org.chromium.@0	6 rule com.google.** com.android.org.chromium.@0

3 rule com.googlecode.** com.android.org.chromium.@0	7 rule com.googlecode.** com.android.org.chromium.@0

4 rule javax.annotation.** com.android.org.chromium.@0	8 rule javax.annotation.** com.android.org.chromium.@0

OLD	NEW