Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2556123002: [turbofan] Further adapting machine graph verifier to code stubs. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Further adapting machine graph verifier to code stubs. All accessor IC stubs now pass the verification. BUG= Committed: https://crrev.com/c522c6baa57948e9698cee14b815553f1563ec5e Cr-Commit-Position: refs/heads/master@{#41585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -10 lines) Patch
M src/code-stub-assembler.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 5 chunks +16 lines, -10 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-07 16:58:30 UTC) #5
epertoso
lgtm
4 years ago (2016-12-08 11:21:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556123002/20001
4 years ago (2016-12-08 11:29:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-08 11:31:03 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 11:31:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c522c6baa57948e9698cee14b815553f1563ec5e
Cr-Commit-Position: refs/heads/master@{#41585}

Powered by Google App Engine
This is Rietveld 408576698