Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2556103002: Changed the css feature name trace string to avoid collisions (Closed)

Created:
4 years ago by Pat Meenan
Modified:
4 years ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed the css feature name trace string to avoid collisions We recently changed the feature-usage trace events to use the stable CSS property ID. This changes the label for the trace events so tools can deterministically know that they are getting the new, stable property ID's. BUG=671731 Committed: https://crrev.com/941bbccd519d77ed2a7ce32be3860e6fc091dccd Cr-Commit-Position: refs/heads/master@{#437042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Pat Meenan
rbyers@ - Sorry I missed this in yesterday's CL. I just realized that WPT could ...
4 years ago (2016-12-07 16:23:19 UTC) #2
Rick Byers
lgtm
4 years ago (2016-12-07 16:50:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556103002/1
4 years ago (2016-12-07 17:24:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 20:05:54 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 20:08:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/941bbccd519d77ed2a7ce32be3860e6fc091dccd
Cr-Commit-Position: refs/heads/master@{#437042}

Powered by Google App Engine
This is Rietveld 408576698