Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2556073002: Remove Compiler.openWorld (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years ago (2016-12-07 14:48:23 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-07 21:40:41 UTC) #3
Johnni Winther
4 years ago (2016-12-08 09:20:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fa038d003baa411f2f39d70c73eb745b9707fc56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698