[blink] Support moving timers between WebTaskRunners

third_party/WebKit/Source/platform/Timer.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 67 matching lines @@
 }
 
 double TimerBase::nextFireInterval() const {
   ASSERT(isActive());
   double current = timerMonotonicallyIncreasingTime();
   if (m_nextFireTime < current)
     return 0;
   return m_nextFireTime - current;
 }
 
+void TimerBase::moveToNewTaskRunner(WebTaskRunner* taskRunner) {
+#if DCHECK_IS_ON()
+  DCHECK_EQ(m_thread, currentThread());
+  DCHECK(taskRunner->runsTasksOnCurrentThread());
+#endif
+  TRACE_EVENT0("blink", "TimerBase::moveToNewTaskRunner");

[Sami, 2016/12/07 18:58:13]

Might want to check if we're already on |taskRunner| (tip: you can compare the
underlying SingleThreadedTaskRunner).

[haraken, 2016/12/08 01:37:20]

Do you really want to have the trace event? moveToNewTaskRunner is not doing
anything heavy.

[altimin, 2016/12/08 14:14:38]

Done.

[altimin, 2016/12/08 14:14:38]

Agreed, removed.

+
+  m_weakPtrFactory.revokeAll();
+
+  m_webTaskRunner = std::unique_ptr<WebTaskRunner>(taskRunner->clone());

[dcheng, 2016/12/07 18:59:57]

Nit: clone() already returns a unique_ptr, doesn't it?

[altimin, 2016/12/08 14:14:38]

Thanks.

+
+  double now = timerMonotonicallyIncreasingTime();
+  double nextFireTime = m_nextFireTime;
+  m_nextFireTime = 0;

[haraken, 2016/12/08 01:37:20]

Line 100 and 101 wouldn't be needed. I think you can just call:

  setNextFireTime(now, m_nextFireTime - now);

[altimin, 2016/12/08 14:14:38]

They are needed because of line 127. setNextFireTime compares newTime with
m_nextFireTime and does nothing if they are equal.

+
+  setNextFireTime(now, nextFireTime - now);
+}
+
 // static
 WebTaskRunner* TimerBase::getTimerTaskRunner() {
   return Platform::current()->currentThread()->scheduler()->timerTaskRunner();
 }
 
 // static
 WebTaskRunner* TimerBase::getUnthrottledTaskRunner() {
   return Platform::current()->currentThread()->getWebTaskRunner();
 }
 
@@ skipping 55 matching lines @@
                                        const TimerBase* b) const {
   return a->m_nextFireTime < b->m_nextFireTime;
 }
 
 // static
 double TimerBase::timerMonotonicallyIncreasingTime() const {
   return timerTaskRunner()->monotonicallyIncreasingVirtualTimeSeconds();
 }
 
 }  // namespace blink