Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2556033002:
Add GPU FYI Linux Ozone builder. (Closed)
|
Created:
4 years ago by fjhenigman Modified:
4 years ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd GPU FYI Linux Ozone builder.
BUG=angleproject:1423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/850eb5b4e0ad058256f580aec4f56712dc5d71d8
Cr-Commit-Position: refs/heads/master@{#437488}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add GPU FYI Linux Ozone builder. #Patch Set 3 : Add GPU FYI Linux Ozone builder. #
Total comments: 4
Patch Set 4 : Add GPU FYI Linux Ozone builder. #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 ========== to ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
jmadill@chromium.org changed reviewers: + jmadill@chromium.org
looks good with the change to mbl https://codereview.chromium.org/2556033002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2556033002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:236: 'Linux ChromiumOS Ozone Builder': 'chromeos_with_codecs_ozone_release_bot', this should be gpu_fyi_tests_chromeos_ozone_release_trybot, and should include the correct mixins for a GPU bot as well as ozone (see the above non-ozone gpu bot and the ozone bot you cite here)
Description was changed from ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
fjhenigman@chromium.org changed reviewers: + dpranke@chromium.org, kbr@chromium.org
ptal
https://codereview.chromium.org/2556033002/diff/40001/content/test/gpu/genera... File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2556033002/diff/40001/content/test/gpu/genera... content/test/gpu/generate_buildbot_json.py:137: 'Linux ChromiumOS Ozone Builder' : {}, Do you want the additional_compile_targets from the builder above? https://codereview.chromium.org/2556033002/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2556033002/diff/40001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1149: 'gpu_fyi_tests', 'release_trybot', 'ozone', I think you meant 'chromeos', 'ozone'.
lgtm w/ ken's comments addressed.
lgtm once my comments are addressed too
https://codereview.chromium.org/2556033002/diff/40001/content/test/gpu/genera... File content/test/gpu/generate_buildbot_json.py (right): https://codereview.chromium.org/2556033002/diff/40001/content/test/gpu/genera... content/test/gpu/generate_buildbot_json.py:137: 'Linux ChromiumOS Ozone Builder' : {}, On 2016/12/07 22:27:10, Ken Russell wrote: > Do you want the additional_compile_targets from the builder above? Dunno - not sure why that bot needs it. Perhaps because it is compile-only? This build will be tested similarly those which don't have additional_compile_targets, so I think I'll try without and add later if needed. https://codereview.chromium.org/2556033002/diff/40001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2556033002/diff/40001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1149: 'gpu_fyi_tests', 'release_trybot', 'ozone', On 2016/12/07 22:27:11, Ken Russell wrote: > I think you meant 'chromeos', 'ozone'. Yep, looks like both magic words are necessary to enable the ozone_platform_gbm setting that gets my bits to build.
The CQ bit was checked by fjhenigman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2556033002/#ps60001 (title: "Add GPU FYI Linux Ozone builder.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by fjhenigman@chromium.org
The CQ bit was checked by fjhenigman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481259264073520,
"parent_rev": "c8c9ceda4d8679c3c8d961c4285d949e051ac68a", "commit_rev":
"3a1a07641c5dbb1f28dd10a83dbb58194dfed9aa"}
Message was sent while issue was closed.
Description was changed from ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Add GPU FYI Linux Ozone builder. BUG=angleproject:1423 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/850eb5b4e0ad058256f580aec4f56712dc5d71d8 Cr-Commit-Position: refs/heads/master@{#437488} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/850eb5b4e0ad058256f580aec4f56712dc5d71d8 Cr-Commit-Position: refs/heads/master@{#437488}
Message was sent while issue was closed.
On 2016/12/09 04:38:45, fjhenigman wrote: > https://codereview.chromium.org/2556033002/diff/40001/content/test/gpu/genera... > File content/test/gpu/generate_buildbot_json.py (right): > > https://codereview.chromium.org/2556033002/diff/40001/content/test/gpu/genera... > content/test/gpu/generate_buildbot_json.py:137: 'Linux ChromiumOS Ozone Builder' > : {}, > On 2016/12/07 22:27:10, Ken Russell wrote: > > Do you want the additional_compile_targets from the builder above? > > Dunno - not sure why that bot needs it. Perhaps because it is compile-only? > This build will be tested similarly those which don't have > additional_compile_targets, so I think I'll try without and add later if needed. This bot also needs additional_compile_targets for all/All. It's only building aura_builder currently. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
