Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/gn/target.cc

Issue 255603004: Forward dependent configs from groups properly in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target.h ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 0763a8c7d9098ce6b336df81c9fdedd082e72fb0..259fcf50bb793c46cee8b794b8eaf89f0c1d0e7d 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -147,6 +147,7 @@ void Target::OnResolved() {
// pulled from G to A in case G has configs directly on it).
PullDependentTargetInfo(&unique_configs);
}
+ PullForwardedDependentConfigs();
}
bool Target::IsLinkable() const {
@@ -181,6 +182,12 @@ void Target::PullDependentTargetInfo(std::set<const Config*>* unique_configs) {
all_libs_.append(dep->all_libs());
}
}
+}
+
+void Target::PullForwardedDependentConfigs() {
+ // Groups implicitly forward all if its dependency's configs.
+ if (output_type() == GROUP)
+ forward_dependent_configs_ = deps_;
// Forward direct dependent configs if requested.
for (size_t dep = 0; dep < forward_dependent_configs_.size(); dep++) {
« no previous file with comments | « tools/gn/target.h ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698