Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: tools/gn/target.h

Issue 255603004: Forward dependent configs from groups properly in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_TARGET_H_ 5 #ifndef TOOLS_GN_TARGET_H_
6 #define TOOLS_GN_TARGET_H_ 6 #define TOOLS_GN_TARGET_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 const ActionValues& action_values() const { return action_values_; } 143 const ActionValues& action_values() const { return action_values_; }
144 144
145 const OrderedSet<SourceDir>& all_lib_dirs() const { return all_lib_dirs_; } 145 const OrderedSet<SourceDir>& all_lib_dirs() const { return all_lib_dirs_; }
146 const OrderedSet<std::string>& all_libs() const { return all_libs_; } 146 const OrderedSet<std::string>& all_libs() const { return all_libs_; }
147 147
148 private: 148 private:
149 // Pulls necessary information from dependents to this one when all 149 // Pulls necessary information from dependents to this one when all
150 // dependencies have been resolved. 150 // dependencies have been resolved.
151 void PullDependentTargetInfo(std::set<const Config*>* unique_configs); 151 void PullDependentTargetInfo(std::set<const Config*>* unique_configs);
152 152
153 // Pulls dependent configs that need forwarding.
154 void PullForwardedDependentConfigs();
155
153 OutputType output_type_; 156 OutputType output_type_;
154 std::string output_name_; 157 std::string output_name_;
155 std::string output_extension_; 158 std::string output_extension_;
156 159
157 FileList sources_; 160 FileList sources_;
158 bool all_headers_public_; 161 bool all_headers_public_;
159 FileList public_headers_; 162 FileList public_headers_;
160 FileList source_prereqs_; 163 FileList source_prereqs_;
161 FileList data_; 164 FileList data_;
162 165
(...skipping 30 matching lines...) Expand all
193 OrderedSet<SourceDir> all_lib_dirs_; 196 OrderedSet<SourceDir> all_lib_dirs_;
194 OrderedSet<std::string> all_libs_; 197 OrderedSet<std::string> all_libs_;
195 198
196 ConfigValues config_values_; // Used for all binary targets. 199 ConfigValues config_values_; // Used for all binary targets.
197 ActionValues action_values_; // Used for action[_foreach] targets. 200 ActionValues action_values_; // Used for action[_foreach] targets.
198 201
199 DISALLOW_COPY_AND_ASSIGN(Target); 202 DISALLOW_COPY_AND_ASSIGN(Target);
200 }; 203 };
201 204
202 #endif // TOOLS_GN_TARGET_H_ 205 #endif // TOOLS_GN_TARGET_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698