printing/features/features.gni - Issue 2556023002: Added flags for PrintBrowser mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: printing/features/features.gni

Issue 2556023002: Added flags for PrintBrowser mode (Closed)

Patch Set: Fix git weirdness Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« printing/features/BUILD.gn ('K') | « printing/features/BUILD.gn ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/chromecast_build.gni")	5 import("//build/config/chromecast_build.gni")

6 import("//build/config/features.gni")	6 import("//build/config/features.gni")

7	7

8 declare_args() {	8 declare_args() {

9 # Enable basic printing support and UI.	9 # Enable basic printing support and UI.

10 enable_basic_printing = !is_chromecast && !is_ios	10 enable_basic_printing = !is_chromecast && !is_ios

11	11

12 # Enable printing with print preview. It does not imply	12 # Enable printing with print preview. It does not imply

13 # enable_basic_printing. It's possible to build Chrome with preview only.	13 # enable_basic_printing. It's possible to build Chrome with preview only.

14 enable_print_preview = !is_android && !is_chromecast && !is_ios	14 enable_print_preview = !is_android && !is_chromecast && !is_ios

15	15

16 use_cups = (is_desktop_linux \|\| is_mac) && !is_chromecast	16 use_cups = (is_desktop_linux \|\| is_mac) && !is_chromecast

17 }	17 }

	18

	19 declare_args() {

	20 # Enable Print Browser mode. Defaults to enable_print_preview.

	21 enable_print_browser = enable_print_preview
	skau 2016/12/16 18:05:53 It is surprising that print preview implies print It is surprising that print preview implies print browser is enabled. Please default the value to false. Print Preview is enabled on most platforms so the feature will effectively be enabled for most platforms.
	22 }

OLD	NEW