Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h

Issue 2556013002: Fix paint property under-invalidation checking about reference filters (Closed)
Patch Set: Fix paint property under-invalidation checking about reference filters Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h b/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
index fd8a894eb5bf7b1a6ec84be761ac2fe1282a621f..55201806f78f625a0db57867329ae9e0d7880d9f 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
@@ -76,12 +76,13 @@ class PLATFORM_EXPORT EffectPaintPropertyNode
}
// The equality operator is used by FindPropertiesNeedingUpdate.h for checking
- // if an effect node has changed.
+ // if an effect node has changed. It ignores changes of reference filters
+ // because SkImageFilter doesn't have an equality operator.
bool operator==(const EffectPaintPropertyNode& o) const {
return m_parent == o.m_parent &&
m_localTransformSpace == o.m_localTransformSpace &&
- m_outputClip == o.m_outputClip && m_filter == o.m_filter &&
- m_opacity == o.m_opacity;
+ m_outputClip == o.m_outputClip && m_opacity == o.m_opacity &&
+ m_filter.equalsIgnoringReferenceFilters(o.m_filter);
}
#endif
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698