third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h - Issue 2556013002: Fix paint property under-invalidation checking about reference filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h

Issue 2556013002: Fix paint property under-invalidation checking about reference filters (Closed)

Patch Set: Fix paint property under-invalidation checking about reference filters Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h

diff --git a/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h b/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h

index 57a709523a4664fcebbda275e197673abc490fe2..d1cef2719ae727af2be7873e051045da852ebd22 100644

--- a/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h

+++ b/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.h

@@ -40,11 +40,17 @@ class PLATFORM_EXPORT CompositorFilterOperations {

void clear();

bool isEmpty() const;

+ // For reference filters, this equality operator compares pointers of the

+ // image_filter fields instead of their values.

bool operator==(const CompositorFilterOperations&) const;

bool operator!=(const CompositorFilterOperations& o) const {

return !(*this == o);

}

+#if DCHECK_IS_ON()

+ bool equalsIgnoringReferenceFilters(const CompositorFilterOperations&) const;

+#endif

private:

cc::FilterOperations m_filterOperations;

};