Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h

Issue 2556013002: Fix paint property under-invalidation checking about reference filters (Closed)
Patch Set: - Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h
diff --git a/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h b/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h
index cf648c6e1b1cbbb9122a5663557fab281c0cd463..e444b3f47449735ceef60ff52fb19bc024e9d978 100644
--- a/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h
+++ b/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h
@@ -140,8 +140,14 @@ class FindObjectPropertiesNeedingUpdateScope {
objectProperties->paintOffsetTranslation());
DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->transform(),
objectProperties->transform());
+ // This check ignores changes of reference filters.
DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->effect(),
objectProperties->effect());
+ // This remedies the above ignored check of reference filters.
+ DCHECK(m_originalProperties->styleFilterOperations() ==
+ objectProperties->styleFilterOperations())
+ << "Filter operations were updated without the layout object ("
+ << m_object.debugName() << ") needing a paint property update.";
DCHECK_OBJECT_PROPERTY_EQ(m_object, m_originalProperties->cssClip(),
objectProperties->cssClip());
DCHECK_OBJECT_PROPERTY_EQ(m_object,

Powered by Google App Engine
This is Rietveld 408576698