Fix paint property under-invalidation checking about reference filters

third_party/WebKit/Source/core/paint/ObjectPaintProperties.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ObjectPaintProperties_h
 #define ObjectPaintProperties_h
 
 #include "core/CoreExport.h"
 #include "platform/geometry/LayoutPoint.h"
 #include "platform/graphics/paint/ClipPaintPropertyNode.h"
 #include "platform/graphics/paint/EffectPaintPropertyNode.h"
 #include "platform/graphics/paint/PaintChunkProperties.h"
 #include "platform/graphics/paint/PropertyTreeState.h"
 #include "platform/graphics/paint/ScrollPaintPropertyNode.h"
 #include "platform/graphics/paint/TransformPaintPropertyNode.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/RefPtr.h"
 #include <memory>
 
+#if DCHECK_IS_ON()
+#include "core/style/FilterOperations.h"
+#endif
+
 namespace blink {
 
 // This class stores property tree related information associated with a
 // LayoutObject.
 // Currently there are two groups of information:
 // 1. The set of property nodes created locally by this LayoutObject.
 // 2. The set of property nodes (inherited, or created locally) and paint offset
 //    that can be used to paint the border box of this LayoutObject (see:
 //    localBorderBoxProperties).
 class CORE_EXPORT ObjectPaintProperties {
@@ skipping 245 matching lines @@
     if (m_scroll)
       cloned->m_scroll = m_scroll->clone();
     if (m_localBorderBoxProperties) {
       auto& state = m_localBorderBoxProperties->propertyTreeState;
       cloned->m_localBorderBoxProperties =
           wrapUnique(new PropertyTreeStateWithOffset(
               m_localBorderBoxProperties->paintOffset,
               PropertyTreeState(state.transform(), state.clip(), state.effect(),
                                 state.scroll())));
     }
+    cloned->setStyleFilterOperations(m_styleFilterOperations);
     return cloned;
   }
+
+  // Used to check changes of filters, especially reference filters which are
+  // ignored in EffectPaintPropertyNode::operator==() because we have no way to
+  // check equality of SkImageFilter values.
+  const FilterOperations& styleFilterOperations() const {
+    return m_styleFilterOperations;
+  }
+  void setStyleFilterOperations(const FilterOperations& operations) {
+    m_styleFilterOperations = operations;
+  }
+  DEFINE_INLINE_TRACE() { visitor->trace(m_styleFilterOperations); }
 #endif
 
  private:
   ObjectPaintProperties() {}
 
   // True if an existing property was deleted, false otherwise.
   template <typename PaintPropertyNode>
   bool clear(RefPtr<PaintPropertyNode>& field) {
     if (field) {
       field = nullptr;
@@ skipping 21 matching lines @@
   RefPtr<ClipPaintPropertyNode> m_innerBorderRadiusClip;
   RefPtr<ClipPaintPropertyNode> m_overflowClip;
   RefPtr<TransformPaintPropertyNode> m_perspective;
   // TODO(pdr): Only LayoutSVGRoot needs this and it should be moved there.
   RefPtr<TransformPaintPropertyNode> m_svgLocalToBorderBoxTransform;
   RefPtr<TransformPaintPropertyNode> m_scrollTranslation;
   RefPtr<TransformPaintPropertyNode> m_scrollbarPaintOffset;
   RefPtr<ScrollPaintPropertyNode> m_scroll;
 
   std::unique_ptr<PropertyTreeStateWithOffset> m_localBorderBoxProperties;
+
+#if DCHECK_IS_ON()
+  FilterOperations m_styleFilterOperations;
+#endif
 };
 
 }  // namespace blink
 
 #endif  // ObjectPaintProperties_h