Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2555973002: Views (native UI) overlay scrollbars: match blink overlay scrollbar (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, bokan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Views (native UI) overlay scrollbars: match blink overlay scrollbar behavior by not showing the scrollbar on hover. We do, however, keep the scrollbar visible if it's already visible and then hovered. BUG=669810 Committed: https://crrev.com/b9232bb95ce16908bb79ed86257b89aa9e2ab4a2 Cr-Commit-Position: refs/heads/master@{#437023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M ui/views/controls/scrollbar/overlay_scroll_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 2 chunks +21 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Evan Stade
4 years ago (2016-12-07 02:41:30 UTC) #2
sadrul
lgtm
4 years ago (2016-12-07 17:38:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555973002/1
4 years ago (2016-12-07 18:55:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 19:04:03 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 19:06:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9232bb95ce16908bb79ed86257b89aa9e2ab4a2
Cr-Commit-Position: refs/heads/master@{#437023}

Powered by Google App Engine
This is Rietveld 408576698