Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2555923003: Make InvalidatableInterpolation's InterpolationTypes decided at effect application time (Closed)
Patch Set: Extended InterpolationTypesMap lifetime scope to fix release crash Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 6c7113acb95d3776cc8b0aa67160bf524d635d21..41faa2662a826ee248b43067cc8304c4300be1c5 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -33,6 +33,7 @@
#include "core/animation/ElementAnimations.h"
#include "core/animation/InterpolationEnvironment.h"
#include "core/animation/InvalidatableInterpolation.h"
+#include "core/animation/SVGInterpolationTypesMap.h"
#include "core/css/CSSCursorImageValue.h"
#include "core/css/resolver/StyleResolver.h"
#include "core/dom/Document.h"
@@ -234,8 +235,9 @@ void SVGElement::applyActiveWebAnimations() {
KeyframeEffectReadOnly::DefaultPriority, isSVGAttributeHandle);
for (auto& entry : activeInterpolationsMap) {
const QualifiedName& attribute = entry.key.svgAttribute();
+ SVGInterpolationTypesMap map;
InterpolationEnvironment environment(
- *this, propertyFromAttribute(attribute)->baseValueBase());
+ map, *this, propertyFromAttribute(attribute)->baseValueBase());
InvalidatableInterpolation::applyStack(entry.value, environment);
}
svgRareData()->setWebAnimatedAttributesDirty(false);
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698