third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Small rebase fixes Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutTextTest.cpp ('K') | « third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

index 11a3c50ca2edf1c1a730246074859c942b07dab6..f689dc35530124ef78711efac92a6acc8608be96 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

@@ -198,7 +198,8 @@ void NGLayoutInlineItemsBuilder::RemoveTrailingCollapsibleSpace(

void NGLayoutInlineItemsBuilder::AppendBidiControl(const ComputedStyle* style,

UChar ltr,

UChar rtl) {

- AppendAsOpaqueToSpaceCollapsing(style->direction() == RTL ? rtl : ltr);

+ AppendAsOpaqueToSpaceCollapsing(

+ style->direction() == TextDirection::Rtl ? rtl : ltr);

}

void NGLayoutInlineItemsBuilder::EnterBlock(const ComputedStyle* style) {