third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Small rebase fixes Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index 5f6d4e11c48bcd7583802123b4b76faed597561a..5ea07a8bf13301058cf5c55b1255c701a8072e41 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -462,8 +462,8 @@ void HTMLFormControlElement::updateVisibleValidationMessage() {

m_hasValidationMessage = true;

ValidationMessageClient* client = &page->validationMessageClient();

- TextDirection messageDir = LTR;

- TextDirection subMessageDir = LTR;

+ TextDirection messageDir = TextDirection::Ltr;

+ TextDirection subMessageDir = TextDirection::Ltr;

String subMessage = validationSubMessage().stripWhiteSpace();

if (message.isEmpty())

client->hideValidationMessage(*this);