Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp
diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
index c15d291ad05d05385d0144379865f9bfe99414f3..8b4b79aac0d7f03a1321a10814544ba322e7e873 100644
--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp
+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
@@ -319,9 +319,11 @@ void PopupMenuImpl::addElementStyle(ItemIterationContext& context,
if (style->display() == EDisplay::None)
addProperty("display", String("none"), data);
const ComputedStyle& baseStyle = context.baseStyle();
- if (baseStyle.direction() != style->direction())
- addProperty("direction", String(style->direction() == RTL ? "rtl" : "ltr"),
- data);
+ if (baseStyle.direction() != style->direction()) {
+ addProperty(
+ "direction",
+ String(style->direction() == TextDirection::Rtl ? "rtl" : "ltr"), data);
+ }
if (isOverride(style->unicodeBidi()))
addProperty("unicodeBidi", String("bidi-override"), data);
Color foregroundColor = style->visitedDependentColor(CSSPropertyColor);

Powered by Google App Engine
This is Rietveld 408576698