third_party/WebKit/Source/platform/text/TextDirection.h - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/TextDirection.h

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/TextDirection.h

diff --git a/third_party/WebKit/Source/platform/text/TextDirection.h b/third_party/WebKit/Source/platform/text/TextDirection.h

index 6bc0bca7fd92d3b04011dc2e395f5339c3a36929..e67698ae53c34374846181d52162ca34f6a7c9ef 100644

--- a/third_party/WebKit/Source/platform/text/TextDirection.h

+++ b/third_party/WebKit/Source/platform/text/TextDirection.h

@@ -28,10 +28,10 @@

namespace blink {

-enum TextDirection { RTL, LTR };

+enum class TextDirection : unsigned { Rtl, Ltr };

sashab 2016/12/07 01:59:43 Main change is here

inline bool isLeftToRightDirection(TextDirection direction) {

- return direction == LTR;

+ return direction == TextDirection::Ltr;

}