third_party/WebKit/Source/web/ExternalPopupMenu.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

index 4fa600c2f81abe70f24a4370f4389a025614f785..2fe19c3672dc57d4f9bfc46075ea5a1333653e50 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

@@ -266,7 +266,7 @@ void ExternalPopupMenu::getPopupMenuInfo(WebPopupMenuInfo& info,

static_cast<int>(menuStyle.font().getFontDescription().computedSize());

info.selectedIndex = toExternalPopupMenuItemIndex(

ownerElement.selectedListIndex(), ownerElement);

- info.rightAligned = menuStyle.direction() == RTL;

+ info.rightAligned = menuStyle.direction() == TextDirection::Rtl;

info.allowMultipleSelection = ownerElement.isMultiple();

if (count < itemCount)

items.shrink(count);