third_party/WebKit/Source/platform/text/BidiTextRun.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/BidiTextRun.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/BidiTextRun.cpp

diff --git a/third_party/WebKit/Source/platform/text/BidiTextRun.cpp b/third_party/WebKit/Source/platform/text/BidiTextRun.cpp

index bd038e2fc26622c46efe3af2c99dcf3ad694286b..3caf3bf0d48041f65d4eb24999ef3fedbe0ddd33 100644

--- a/third_party/WebKit/Source/platform/text/BidiTextRun.cpp

+++ b/third_party/WebKit/Source/platform/text/BidiTextRun.cpp

@@ -39,7 +39,7 @@ TextDirection directionForRun(TextRun& run, bool* hasStrongDirectionality) {

if (!hasStrongDirectionality) {

// 8bit is Latin-1 and therefore is always LTR.

if (run.is8Bit())

- return LTR;

+ return TextDirection::Ltr;

// length == 1 for more than 90% of cases of width() for CJK text.

if (run.length() == 1 && U16_IS_SINGLE(run.characters16()[0]))