third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h

index 517bca89c123b92591d5b1b6b784876f7a8a3420..5b7774ece299f6bb8f2be85b775fa86789adec48 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h

@@ -67,7 +67,9 @@ class PLATFORM_EXPORT ShapeResult : public RefCounted<ShapeResult> {

const FloatRect& bounds() const { return m_glyphBoundingBox; }

unsigned numCharacters() const { return m_numCharacters; }

void fallbackFonts(HashSet<const SimpleFontData*>*) const;

- bool rtl() const { return m_direction == RTL; }

+ bool rtl() const {

+ return static_cast<TextDirection>(m_direction) == TextDirection::Rtl;

+ }

bool hasVerticalOffsets() const { return m_hasVerticalOffsets; }

// For memory reporting.