third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

index a1c2a4eb7d9c94a5bc0daa2dcb0bf5c24286650b..7a23509003b46d702f298cc16ea445fbcc4742e8 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

@@ -108,8 +108,8 @@ static inline hb_direction_t TextDirectionToHBDirection(

!fontData->isTextOrientationFallback()

? HB_DIRECTION_TTB

: HB_DIRECTION_LTR;

- return dir == RTL ? HB_DIRECTION_REVERSE(harfBuzzDirection)

- : harfBuzzDirection;

+ return dir == TextDirection::Rtl ? HB_DIRECTION_REVERSE(harfBuzzDirection)

+ : harfBuzzDirection;

}

inline bool shapeRange(hb_buffer_t* harfBuzzBuffer,