third_party/WebKit/Source/platform/fonts/Font.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/Font.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/Font.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/Font.cpp b/third_party/WebKit/Source/platform/fonts/Font.cpp

index 185d7137847b53cc8073f105ff83d13736cacf63..838080911c8a562cb2cf2ca0061863304cbaf698 100644

--- a/third_party/WebKit/Source/platform/fonts/Font.cpp

+++ b/third_party/WebKit/Source/platform/fonts/Font.cpp

@@ -180,7 +180,7 @@ bool Font::drawBidiText(SkCanvas* canvas,

TextRun subrun =

run.subRun(bidiRun->start(), bidiRun->stop() - bidiRun->start());

bool isRTL = bidiRun->level() % 2;

- subrun.setDirection(isRTL ? RTL : LTR);

+ subrun.setDirection(isRTL ? TextDirection::Rtl : TextDirection::Ltr);

subrun.setDirectionalOverride(bidiRun->dirOverride(false));

TextRunPaintInfo subrunInfo(subrun);