third_party/WebKit/Source/platform/DragImage.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/DragImage.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/DragImage.cpp

diff --git a/third_party/WebKit/Source/platform/DragImage.cpp b/third_party/WebKit/Source/platform/DragImage.cpp

index 76047fa1191388a8bbb0f14ebdb1b5f0d92815c1..2521f81cedfba74a14507332f3015ae8f9ad2cf1 100644

--- a/third_party/WebKit/Source/platform/DragImage.cpp

+++ b/third_party/WebKit/Source/platform/DragImage.cpp

@@ -291,7 +291,7 @@ std::unique_ptr<DragImage> DragImage::create(const KURL& url,

IntPoint textPos(

kDragLabelBorderX,

kDragLabelBorderY + labelFont.getFontDescription().computedPixelSize());

- if (hasStrongDirectionality && textRun.direction() == RTL) {

+ if (hasStrongDirectionality && textRun.direction() == TextDirection::Rtl) {

float textWidth = labelFont.width(textRun);

int availableWidth = imageSize.width() - kDragLabelBorderX * 2;

textPos.setX(availableWidth - ceilf(textWidth));