third_party/WebKit/Source/core/testing/Internals.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/Internals.cpp

diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp

index 7e917309b2eabc2c1ebcb23d3718f5d386598ea2..caa2c4446c14d6e06cb9ffdfe5d3b7bd22cbf8bd 100644

--- a/third_party/WebKit/Source/core/testing/Internals.cpp

+++ b/third_party/WebKit/Source/core/testing/Internals.cpp

@@ -2638,7 +2638,7 @@ bool Internals::selectPopupItemStyleIsRtl(Node* node, int itemIndex) {

return false;

const ComputedStyle* itemStyle =

select.itemComputedStyle(*select.listItems()[itemIndex]);

- return itemStyle && itemStyle->direction() == RTL;

+ return itemStyle && itemStyle->direction() == TextDirection::Rtl;

}

int Internals::selectPopupItemStyleFontHeight(Node* node, int itemIndex) {