third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

index 0b1c4bf1b17f54ee6e2c8baa75bb402ffd2280c7..f5f7ad34b2f06c9aa44a24fb1c95d2be02a248d7 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

@@ -335,7 +335,7 @@ void LayoutSVGInlineText::updateMetricsList(bool& lastCharacterWasWhiteSpace) {

BidiResolver<TextRunIterator, BidiCharacterRun> bidiResolver;

BidiRunList<BidiCharacterRun>& bidiRuns = bidiResolver.runs();

bool bidiOverride = isOverride(styleRef().unicodeBidi());

- BidiStatus status(LTR, bidiOverride);

+ BidiStatus status(TextDirection::Ltr, bidiOverride);

if (run.is8Bit() || bidiOverride) {

WTF::Unicode::CharDirection direction = WTF::Unicode::LeftToRight;

// If BiDi override is in effect, use the specified direction.