third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_units.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

index 0a2be7d7f485e59bd865b400118add3204272777..afdee65733d41fe018a68dc4b2bffe1fba9f3fa3 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc

@@ -86,8 +86,8 @@ void NGTextLayoutAlgorithm::CreateLine(

if (!inline_box_->IsBidiEnabled()) {

// If no bidi reordering, the logical order is the visual order.

- DCHECK_EQ(constraint_space.Direction(), LTR);

- DCHECK_EQ(items[0].Style()->direction(), LTR);

+ DCHECK_EQ(constraint_space.Direction(), TextDirection::Ltr);

+ DCHECK_EQ(items[0].Style()->direction(), TextDirection::Ltr);

fragments_out->append(new NGTextFragment(

constraint_space.WritingMode(), constraint_space.Direction(),

text_builder.ToTextFragment(inline_box_, items.StartIndex(),