Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
index 88e33dbf4f821007c46b995aba3d1a91cf6b693b..8f409f744a07136967c75817bb8f891936894302 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc
@@ -187,7 +187,7 @@ TEST_F(NGLayoutInlineItemsBuilderTest, BidiBlockOverride) {
NGLayoutInlineItemsBuilder builder(&items);
RefPtr<ComputedStyle> block_style(ComputedStyle::create());
block_style->setUnicodeBidi(Override);
- block_style->setDirection(RTL);
+ block_style->setDirection(TextDirection::Rtl);
builder.EnterBlock(block_style.get());
builder.Append("Hello", style_.get());
builder.ExitBlock();
@@ -216,7 +216,7 @@ TEST_F(NGLayoutInlineItemsBuilderTest, BidiIsolate) {
std::unique_ptr<LayoutInline> isolateRTL(
createLayoutInline([](ComputedStyle* style) {
style->setUnicodeBidi(Isolate);
- style->setDirection(RTL);
+ style->setDirection(TextDirection::Rtl);
}));
builder.EnterInline(isolateRTL.get());
builder.Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA", style_.get());
@@ -240,7 +240,7 @@ TEST_F(NGLayoutInlineItemsBuilderTest, BidiIsolateOverride) {
std::unique_ptr<LayoutInline> isolateOverrideRTL(
createLayoutInline([](ComputedStyle* style) {
style->setUnicodeBidi(IsolateOverride);
- style->setDirection(RTL);
+ style->setDirection(TextDirection::Rtl);
}));
builder.EnterInline(isolateOverrideRTL.get());
builder.Append(u"\u05E2\u05D1\u05E8\u05D9\u05EA", style_.get());

Powered by Google App Engine
This is Rietveld 408576698