third_party/WebKit/Source/core/layout/ng/ng_inline_node.h - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node.h

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h

index 4f254a9607d486990cfb3e8170425b77a54f9dbe..ef33e2afd47b9a89984b6ca4e84d1e879d98c7f4 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.h

@@ -96,7 +96,9 @@ class NGLayoutInlineItem {

unsigned StartOffset() const { return start_offset_; }

unsigned EndOffset() const { return end_offset_; }

- TextDirection Direction() const { return bidi_level_ & 1 ? RTL : LTR; }

+ TextDirection Direction() const {

+ return bidi_level_ & 1 ? TextDirection::Rtl : TextDirection::Ltr;

+ }

UBiDiLevel BidiLevel() const { return bidi_level_; }

UScriptCode Script() const { return script_; }

const ComputedStyle* Style() const { return style_; }